[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries

From: Corey Minyard
Subject: Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries
Date: Mon, 23 May 2016 14:25:21 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 05/23/2016 01:06 PM, Paolo Bonzini wrote:

On 20/05/2016 11:53, Igor Mammedov wrote:
diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
new file mode 100644
index 0000000..dd7590d
--- /dev/null
+++ b/hw/acpi/noipmi.c
move this to .a/stubs/

Don't overuse stubs.  The stubs library is mostly to share code between
QEMU and the tools.  What Corey did is more similar to what hw/ already
does in other places.

Should I change it back?

Unfortunately, weak symbols are not portable. :(

Yeah, that's really a pain.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]