[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface
Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)
Mon, 23 May 2016 15:52:49 +0200
Resuming to work on this after 2.6 freeze break ...
> I have done some more testing and sent a series for spice-gtk fixing
> display with gl scanout-only case. And a minor patch to spice server
> to solve a cursor initialization when there is no canvas. Your series
> works ok with that, only when doing a reboot, virtio_gpu_virgl_reset()
> calls spice_qxl_gl_scanout( fd = -1), and later spice_gl_refresh()
> calls spice_qxl_gl_draw_async() and reaches the following error:
> (process:21117): Spice-CRITICAL **:
> red-qxl.c:900:spice_qxl_gl_draw_async: condition
> `qxl_state->scanout.drm_dma_buf_fd != -1' failed
Hmm, that is sort-of intentional. It's valid for scanouts to not be
backed by a resource, and in that case qemu_spice_gl_scanout() calls
spice_qxl_gl_scanout() with fd=-1.
So, what do you think we should do here? Fix spice to handle that case?
Should qemu do something else instead? Such as not calling
spice_qxl_gl_scanout() to keep the previous dma-buf alive?
- Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC),
Gerd Hoffmann <=