[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, c
Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, clean up
Mon, 23 May 2016 14:06:51 +0530
On (Fri) 06 May 2016 [15:11:04], Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> > On 05/04/2016 10:49 AM, Markus Armbruster wrote:
> >> qjson.[ch] is a JSON writer used by migration. Eric proposed to
> >> replace it by common code in his "Add qapi-to-JSON and clone visitors"
> >> series. David's review led to the conclusion that migration would
> >> prefer to keep its own JSON writer, to better serve its requirements.
> >> PATCH 1 move it to its proper place, and explains why it exists in a
> >> bit more detail. PATCH 2 simplifies it a bit.
> > Whose tree would this go in through?
> Migration is the natural choice. Would that inconvenience you?
> > At any rate, series:
> > Reviewed-by: Eric Blake <address@hidden>
> > but see nit on 1/2
> Perhaps the maintainer can add the commit hashes on merge.
I'm doing that.