[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify
Date: Mon, 23 May 2016 10:17:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 23/05/2016 04:43, Fam Zheng wrote:
> > The batch notification BH needs to know which virtqueues to notify when
> > multiqueue is enabled.  Use a bitmap to track the virtqueues that with
> > pending notifications.
> This approach works great as long as VQs are in the same iothread. An
> alternative way would be using separate BH per VQ, which will naturely work 
> with
> multi queue block layer in the future.  Should we just go for that in the 
> first
> place?  Seems less code churn, and no imaginable disadvantage compared to this
> patch.

It can be slower because all BHs are walked during aio_bh_poll, not just
the scheduled ones.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]