[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd
Date: Thu, 19 May 2016 17:26:08 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> Pls note, trace_init_backends() must be called in the final process, i.e.


> after daemonization. This is necessary to keep tracing thread in the
> proper process.
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
>  qemu-nbd.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Same comments as on 2/3 - missing documentation - this time, it is the
man page that is incomplete.

> @@ -87,6 +89,7 @@ static void usage(const char *name)
>  "General purpose options:\n"
>  "  --object type,id=ID,...   define an object such as 'secret' for 
> providing\n"
>  "                            passwords and/or encryption keys\n"
> +"  -T, --trace FILE          enable trace events listed in the given file\n"

Insufficient, compared to how qemu's help text reads.

But overall a cool concept.  Are there any plans to convert some of the
TRACE() debugging printfs in nbd/* into actual trace points?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]