Re: [Qemu-devel] [PULL v2 00/52] NEED_CPU_H cleanups

[Peter Maydell]

On 19 May 2016 at 13:12, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
>
>   Merge remote-tracking branch 
> 'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19 
> 09:27:28 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 944d7770b4f4c1807c154b0a4f00ea19932c1a27:
>
>   hw: clean up hw/hw.h includes (2016-05-19 14:10:46 +0200)
>
> ----------------------------------------------------------------
> NEED_CPU_H cleanups, big enough to deserve their own pull request.

Fails to build with clang, which doesn't like multiple identical
typedef definitions:

In file included from /home/petmay01/linaro/qemu-for-merges/cpu-exec.c:23:
In file included from
/home/petmay01/linaro/qemu-for-merges/include/exec/exec-all.h:24:
/home/petmay01/linaro/qemu-for-merges/include/exec/tb-context.h:31:26:
error: redefinition of typedef 'TBContext' is a C11 feature
[-Werror,-Wtypedef-redefinition]
typedef struct TBContext TBContext;
                         ^
/home/petmay01/linaro/qemu-for-merges/include/exec/tb-context.h:29:26:
note: previous definition is here
typedef struct TBContext TBContext;
                         ^
1 error generated.

thanks
-- PMM