Re: [Qemu-devel] [PULL 00/52] NEED_CPU_H cleanups

[Peter Maydell]

On 19 May 2016 at 12:17, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit 8ec4fe0a4bed4fa27e6f28a746bcf77b27cd05a3:
>
>   Merge remote-tracking branch 
> 'remotes/mjt/tags/pull-trivial-patches-2016-05-18' into staging (2016-05-19 
> 09:27:28 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 9a4292cfb84fc62435800086e5cecc7b0a4f7005:
>
>   hw: clean up hw/hw.h includes (2016-05-19 13:08:08 +0200)
>
> ----------------------------------------------------------------
> NEED_CPU_H cleanups, big enough to deserve their own pull request.

I'm afraid this fails to build (all platforms):

In file included from
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.h:21:0,
                 from /home/petmay01/linaro/qemu-for-merges/hw/s390x/sclp.c:25:
/home/petmay01/linaro/qemu-for-merges/include/hw/s390x/css.h:85:20:
error: unknown type name ‘SubchDev’
     int (*ccw_cb) (SubchDev *, CCW1);
                    ^
/home/petmay01/linaro/qemu-for-merges/include/hw/s390x/css.h:86:24:
error: unknown type name ‘SubchDev’
     void (*disable_cb)(SubchDev *);
                        ^

thanks
-- PMM