[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass d
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols |
Date: |
Thu, 19 May 2016 05:49:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 18.05.2016 18:36, Paolo Bonzini wrote:
> Just leave some members in even if they are unused on e.g.
> 32-bit PPC or user-mode emulation. This avoids complications
> when using PowerPCCPUClass in code that is compiled just
> once (because it applies to both 32-bit and 64-bit PPC
> for example) but still needs to peek at PPC-specific members.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-ppc/cpu-qom.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target-ppc/cpu-qom.h b/target-ppc/cpu-qom.h
> index bab501f..6f4e929 100644
> --- a/target-ppc/cpu-qom.h
> +++ b/target-ppc/cpu-qom.h
> @@ -67,14 +67,10 @@ typedef struct PowerPCCPUClass {
> uint32_t flags;
> int bfd_mach;
> uint32_t l1_dcache_size, l1_icache_size;
> -#if defined(TARGET_PPC64)
> const struct ppc_segment_page_sizes *sps;
> -#endif
> void (*init_proc)(CPUPPCState *env);
> int (*check_pow)(CPUPPCState *env);
> -#if defined(CONFIG_SOFTMMU)
> int (*handle_mmu_fault)(PowerPCCPU *cpu, vaddr eaddr, int rwx, int
> mmu_idx);
> -#endif
> bool (*interrupts_big_endian)(PowerPCCPU *cpu);
> } PowerPCCPUClass;
>
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 01/52] scripts: add script to build QEMU and analyze inclusions, (continued)
- [Qemu-devel] [PATCH 01/52] scripts: add script to build QEMU and analyze inclusions, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 32/52] explicitly include linux/kvm.h, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 16/52] target-ppc: make cpu-qom.h not target specific, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 42/52] dma: do not depend on kvm_enabled(), Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 22/52] target-xtensa: make cpu-qom.h not target specific, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 02/52] s390x: move vregs_needed to machine.c, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 14/52] target-ppc: do not use target_ulong in cpu-qom.h, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols, Paolo Bonzini, 2016/05/18
- Re: [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h cleanups, Thomas Huth, 2016/05/19