[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

From: xiaoqiang zhao
Subject: Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c
Date: Wed, 18 May 2016 18:33:38 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

在 2016年05月17日 20:51, Paolo Bonzini 写道:
I'm sorry, this is not enough.  You need to learn how to test this
device.  CRIS images are available athttp://wiki.qemu.org/Testing.

You have not added a replacement for the call to
qemu_char_get_next_serial().  The board code in hw/cris/axis_dev88.c
needs to use qemu_char_get_next_serial().

I suggest creating a function like

     void etraxfs_ser_create(hwaddr addr, qemu_irq irq,
                             CharDriverState *chr) {
         DeviceState *dev;
         SysBusDevice *s;
         qemu_irq irq;

         dev = qdev_create(NULL, "extrafs,serial");
         s = SYS_BUS_DEVICE(dev);
         qdev_prop_set_chr(s, "chardev", chr);
         sysbus_mmio_map(s, 0, addr);
         sysbus_connect_irq(s, 0, irq);
 Oh, I see.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]