[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] qcow2: fix condition in is_zero_cluster
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/5] qcow2: fix condition in is_zero_cluster |
|
Date: |
Tue, 17 May 2016 17:11:05 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.05.2016 um 11:15 hat Denis V. Lunev geschrieben:
> We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we
> will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is
> not possible.
The patch is okay, but I'm correcting this paragraph into:
We should check for (res & BDRV_BLOCK_ZERO) only. The situation when we
will have !(res & BDRV_BLOCK_DATA) and will not have BDRV_BLOCK_ZERO is
not possible for images with bdi.unallocated_blocks_are_zero == true.
For those images where it's false, however, it can happen and we must
not consider the data zeroed then or we would corrupt the image.
Kevin
- [Qemu-devel] [PATCH v2 0/5] qcow2_co_write_zeroes and related improvements, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 4/5] qcow2: fix condition in is_zero_cluster, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH 4/5] qcow2: fix condition in is_zero_cluster,
Kevin Wolf <=
- [Qemu-devel] [PATCH 5/5] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 2/5] qcow2: simplify logic in qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 3/5] qcow2: add tracepoints for qcow2_co_write_zeroes, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 1/5] block: split write_zeroes always, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH v2 0/5] qcow2_co_write_zeroes and related improvements, Kevin Wolf, 2016/05/17