[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-bord
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL |
Date: |
Fri, 13 May 2016 14:32:41 +0200 |
From: Cole Robinson <address@hidden>
VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90)
code checks for the condition too so I assume it's not just a bug
Fixes a crash on Fedora 24 with gtk 3.20
Signed-off-by: Cole Robinson <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/gtk.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index f372a6d..9876d89 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -340,10 +340,12 @@ static void gd_update_geometry_hints(VirtualConsole *vc)
geo.min_height = geo.height_inc * VC_TERM_Y_MIN;
mask |= GDK_HINT_MIN_SIZE;
gtk_widget_style_get(vc->vte.terminal, "inner-border", &ib, NULL);
- geo.base_width += ib->left + ib->right;
- geo.base_height += ib->top + ib->bottom;
- geo.min_width += ib->left + ib->right;
- geo.min_height += ib->top + ib->bottom;
+ if (ib) {
+ geo.base_width += ib->left + ib->right;
+ geo.base_height += ib->top + ib->bottom;
+ geo.min_width += ib->left + ib->right;
+ geo.min_height += ib->top + ib->bottom;
+ }
geo_widget = vc->vte.terminal;
#endif
}
--
1.8.3.1
- [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20, (continued)
- [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 02/17] ui: sdl2: Release grab before opening console window, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 17/17] gtk: don't leak the GtkBorder with VTE 0.36, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 06/17] configure: report GTK version, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 12/17] spice/gl: add & use qemu_spice_gl_monitor_config, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 13/17] Changed malloc to g_malloc, free to g_free in ui/shader.c, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 10/17] ui: gtk: Fix some deprecation warnings, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 07/17] configure: report SDL version, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 05/17] configure: add echo_version helper, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL,
Gerd Hoffmann <=
- [Qemu-devel] [PULL v2 15/17] spice: fix coverity complains, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 09/17] ui: gtk: Fix a runtime warning on vte >= 0.37, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 03/17] configure: build SDL if only SDL2 available, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 14/17] egl-helpers: fix possible resource leak, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 08/17] configure: support vte-2.91, Gerd Hoffmann, 2016/05/13
- Re: [Qemu-devel] [PULL v2 00/17] ui patch queue, Peter Maydell, 2016/05/13