[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu-exec: Clean up 'interrupt_request' reloadin
|
From: |
Sergey Fedorov |
|
Subject: |
Re: [Qemu-devel] [PATCH] cpu-exec: Clean up 'interrupt_request' reloading in cpu_handle_interrupt() |
|
Date: |
Thu, 12 May 2016 19:49:06 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
On 12/05/16 19:47, Richard Henderson wrote:
> On 05/12/2016 04:14 AM, Sergey Fedorov wrote:
>> @@ -489,9 +489,10 @@ static inline void cpu_handle_interrupt(CPUState
>> *cpu,
>> *last_tb = NULL;
>> }
>
> [A]
>
>> }
>> - /* Don't use the cached interrupt_request value,
>> - do_interrupt may have updated the EXITTB flag. */
>> - if (cpu->interrupt_request & CPU_INTERRUPT_EXITTB) {
>> + /* The target hook may have updated the
>> 'cpu->interrupt_request';
>> + * reload the 'interrupt_request' value */
>> + interrupt_request = cpu->interrupt_request;
>> + if (interrupt_request & CPU_INTERRUPT_EXITTB) {
>
> Actually I suggested reloading it after the only place it could have
> changed, at A.
Oops :) Will fix it and resend.
Thanks,
Sergey