[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling

From: Corey Minyard
Subject: Re: [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling
Date: Thu, 12 May 2016 08:26:57 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

On 05/12/2016 02:30 AM, Michael S. Tsirkin wrote:

Thanks for the comments, all fixed.

   * init_aml_allocator:
@@ -327,6 +336,8 @@ Aml *aml_qword_memory(AmlDecode dec, AmlMinFixed min_fixed,
  Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz,
               uint8_t channel);
  Aml *aml_sleep(uint64_t msec);
+Aml *aml_i2c_serial_bus_device(uint8_t flags, uint32_t con_speed,
Drop these two parameters until they are actually useful.

I'm not sure I follow here. The address parameter is important, it's for the I2C address. The top 8 bytes are reserved 0, but not the bottom. The resource source parameter tells which I2C bus it's hooked to.

+                               uint16_t address, const char *resource_source);
/* Block AML object primitives */
  Aml *aml_scope(const char *name_format, ...) GCC_FMT_ATTR(1, 2);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]