[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBa
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend |
Date: |
Wed, 11 May 2016 14:24:05 +0100 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Tue, May 10, 2016 at 12:38:17PM +0200, Paolo Bonzini wrote:
> On 10/05/2016 11:33, Stefan Hajnoczi wrote:
> >> >
> >> > I'm not sure I agree with #2, as we should move away for the
> >> > super-coarse AioContext lock (it is heavyweight and it doesn't play well
> >> > with multiqueue). Atomics can be used for statistics, while the
> >> > time-based accounting probably should be made optional because it's
> >> > heavy-weight and hard to scale.
> >> >
> >> > But I do agree with #1, so the idea seems good.
> > I agree that lightweight options are nicer. Should I resend without #2
> > in the commit description?
>
> Well, it _is_ a valid concern until someone does the work. :)
Okay, then the patch is fine as-is.
Thanks,
Stefan
signature.asc
Description: PGP signature