[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/13] block: Don't check throttled reqs in b

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 13/13] block: Don't check throttled reqs in bdrv_requests_pending()
Date: Wed, 11 May 2016 14:35:10 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 10.05.2016 um 14:20 hat Alberto Garcia geschrieben:
> On Fri 22 Apr 2016 07:42:42 PM CEST, Kevin Wolf wrote:
> > Checking whether there are throttled requests requires going to the
> > associated BlockBackend, which we want to avoid. All users of
> > bdrv_requests_pending() already call bdrv_parent_drained_begin()
> > first,
> There's a couple of assert(!bdrv_requests_pending()), is it also the
> case with them?

I'm changing it into "all users in block/io.c" and adding this paragraph
to the commit message:

    The remaining users (assertions during graph manipulation in
    block.c) don't care about requests that are still queued in the
    BlockBackend and haven't been issued for a BlockDriverState yet.

Makes sense?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]