[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children |
|
Date: |
Wed, 11 May 2016 09:51:24 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, 05/10 10:33, Kevin Wolf wrote:
>
> Fair enough. My series didn't have a separate callback, but with yours
> that should be working.
>
> So is the semantics of .bdrv_inactivate() basically "bdrv_flush, and I
> really mean it"?
Yes.
>
> > > Maybe we need something like an "active reference counter", and we
> > > decrement that for all children and only call their .bdrv_inactivate()
> > > when it arrives at 0.
> >
> > That should work, but the effect of the counters are local to one
> > invocation of
> > bdrv_inactivate_all(), and is not really necessary if we do as above.
>
> Agreed.
Working on another version now.
Fam