[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c |
Date: |
Thu, 5 May 2016 13:47:15 +0100 |
On 5 May 2016 at 04:04, xiaoqiang zhao <address@hidden> wrote:
> * Drop the old SysBus init function and use instance_init
> * Move tmu2_glx_init into realize stage
>
> Signed-off-by: xiaoqiang zhao <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
> +static void milkymist_tmu2_realize(DeviceState *dev, Error **errp)
> +{
> + MilkymistTMU2State *s = MILKYMIST_TMU2(dev);
> +
> + if (tmu2_glx_init(s)) {
> + error_setg(errp, "tmu2_glx_init failed.");
> + }
> }
The milkymist maintainer might have a suggestion for a
more informative error message here.
thanks
-- PMM
- [Qemu-devel] [PATCH RESEND 0/5] QOM'ify hw/display devices, xiaoqiang zhao, 2016/05/04
- [Qemu-devel] [PATCH RESEND 1/5] hw/display: QOM'ify exynos4210_fimd.c, xiaoqiang zhao, 2016/05/04
- [Qemu-devel] [PATCH RESEND 4/5] hw/display: QOM'ify milkymist-vgafb.c, xiaoqiang zhao, 2016/05/04
- [Qemu-devel] [PATCH RESEND 5/5] hw/display: QOM'ify pl110.c, xiaoqiang zhao, 2016/05/04
- [Qemu-devel] [PATCH RESEND 2/5] hw/display: QOM'ify jazz_led.c, xiaoqiang zhao, 2016/05/04