Re: [Qemu-devel] [PATCH RFC] cpu-exec: Restructure cpu_exec()

[Sergey Fedorov]

On 04/05/16 21:04, Richard Henderson wrote:
> On 05/04/2016 03:38 AM, Sergey Fedorov wrote:
>> From: Sergey Fedorov <address@hidden>
>>
>> cpu_exec() was a huge function also sprinkled with some preprocessor
>> directives. It's hard to read and see the main loop crowded by all this
>> code. Restructure cpu_exec() by moving its conceptual parts into
>> separate static in-line functions. That makes it possible to see the
>> whole main loop at once, especially its sigsetjmp() handling part.
>>
>> Signed-off-by: Sergey Fedorov <address@hidden>
>> Signed-off-by: Sergey Fedorov <address@hidden>
>
> I agree that cpu_exec is a shocking horror.  However, this patch is
> hard enough to read that it might be worth splitting.  Is it easy
> enough to pull out each subroutine in a separate patch?

Sure, it's easy. I just wanted to check that this is a right approach
and after this patch applied cpu_exec() is in right shape. I'll prepare
a split patch series later.

Kind regards,
Sergey