[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with
Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht
Wed, 4 May 2016 07:22:16 -1000
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0
On 05/04/2016 05:36 AM, Emilio G. Cota wrote:
BTW in the last couple of days I did some more work beyond v4:
- Added a benchmark (not a correctness test) to measure parallel
performance of QHT (recall that test/qht-test is sequential.)
- Added support for concurrent insertions as long as they're not to the
same bucket, thus getting rid of the "external lock" requirement.
This is not really needed for MTTCG because all insertions are supposed
to be serialized by tb_lock; however, the feature (1) has no negative
performance impact (just adds an unlikely() branch after lock acquisition
on insertions/removals) and (2) could be useful for future (parallel)
users of qht.
Should I send this work as follow-up patches to v4 to ease review, or
should I send a v5 with them merged in?
Let's handle these as follow-on, since we've already got multiple R-b tags for