qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 03/11] block: use the block job list in qmp_q


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v9 03/11] block: use the block job list in qmp_query_block_jobs()
Date: Fri, 29 Apr 2016 16:32:41 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 04.04.2016 um 15:43 hat Alberto Garcia geschrieben:
> qmp_query_block_jobs() uses bdrv_next() to look for block jobs, but
> this function can only find those in top-level BlockDriverStates.
> 
> This patch uses block_job_next() instead.
> 
> Signed-off-by: Alberto Garcia <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

However, I'd like to give you a heads-up that this will technically
conflict with my series that removes BlockDriverState.blk because that
changes the bdrv_next() signature.

Nothing dramatic, but I guess it would make sense to decide where in the
queue of patches this series should go. My suggestion would be on top of
"blockdev: (Nearly) free clean-up work".

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]