[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] configure: Check if struct fsxattr is available fro
From: |
Jan Vesely |
Subject: |
[Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header |
Date: |
Fri, 29 Apr 2016 09:07:59 -0400 |
Fixes build failure with --enable-xfsctl and
new linux headers (>=4.5) and older xfsprogs(<4.5):
In file included from /usr/include/xfs/xfs.h:38:0,
from
/var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
/usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
struct fsxattr {
^
In file included from
/var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
/usr/include/linux/fs.h:155:8: note: originally defined here
struct fsxattr {
CC: address@hidden
CC: Markus Armbruster <address@hidden>
CC: Peter Maydell <address@hidden>
CC: Stefan Weil <address@hidden>
Signed-off-by: Jan Vesely <address@hidden>
---
One can argue that the failure only happens for invalid linux-headers,
xfsprogs combinations, feel free to reject the patch in that case.
This patch relies on functionality introduced in
559607ea173 io: add QIOChannelSocket class
configure | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/configure b/configure
index b88d0db..bb64d6c 100755
--- a/configure
+++ b/configure
@@ -4474,6 +4474,21 @@ if test "$fortify_source" != "no"; then
fi
fi
+########################################
+# check if struct fsxattr is available
+
+have_fsxattr=no
+cat > $TMPC << EOF
+#include <linux/fs.h>
+struct fsxattr foo;
+int main(void) {
+ return 0;
+}
+EOF
+if compile_prog "" "" ; then
+ have_fsxattr=yes
+fi
+
##########################################
# End of CC checks
# After here, no more $cc or $ld runs
@@ -5137,6 +5152,9 @@ fi
if test "$have_ifaddrs_h" = "yes" ; then
echo "HAVE_IFADDRS_H=y" >> $config_host_mak
fi
+if test "$have_fsxattr" = "yes" ; then
+ echo "HAVE_FSXATTR=y" >> $config_host_mak
+fi
if test "$vte" = "yes" ; then
echo "CONFIG_VTE=y" >> $config_host_mak
echo "VTE_CFLAGS=$vte_cflags" >> $config_host_mak
--
2.7.3
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Jan Vesely, 2016/04/12
- [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header,
Jan Vesely <=
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Stefan Weil, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Peter Maydell, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Stefan Weil, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Peter Maydell, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Stefan Weil, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Peter Maydell, 2016/04/29
- Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header, Jan Vesely, 2016/04/29
- [Qemu-devel] [PATCH v2] configure: Check if struct fsxattr is available from linux header, Jan Vesely, 2016/04/29