Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything

[Stefan Weil]

Am 29.04.2016 um 10:51 schrieb Peter Maydell:
> On 28 April 2016 at 22:33, Stefan Weil <address@hidden> wrote:
>> The clang compiler supports a useful compiler option -Weverything.
>>
>> As this option triggers warnings in glib header files, too, testing
>> glib with -Werror will always fail. A size mismatch is also detected
>> without -Werror, so simply remove it.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>
>> With this patch, it is possible to build QEMU using this configuration:
>>
>> ./configure' --cc=clang-3.7 --cxx=clang++-3.7 --extra-cflags="-Weverything 
>> -DHAVE_FSXATTR" --disable-werror
>>
>> (HAVE_FSXATTR avoids a fatal build error because of structure redefinition)
> No objection to the patch, but not for 2.6 at this stage I think.
>
> (Does the configure patch re fsxattr that got a ping today
> avoid your need to define HAVE_FSXATTR by hand?)
>
> thanks
> -- PMM


IMHO the patch is save for 2.6, but I don't insist on getting it into
that version - although I already had the same problem with gcc +
increased warning level (without finding the reason), so it is not
specific for clang.

The configure patch which you are referring to is this one:

"configure: Check if struct fsxattr is available from linux header"

It can be found on qemu-trivial, but not on qemu-devel, patchworks or in
my personal QEMU mails. Obviously this patch only reached qemu-trivial,
but not qemu-devel. Perhaps that's why it did not get more attention.

The patch looks good, and I expect that it would solve the problem which
I observed. Jan, could you please send it a 2nd time (cc me), so I can
test it?

Thanks

Stefan