[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments |
Date: |
Thu, 28 Apr 2016 20:00:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> On Thu, Apr 28, 2016 at 4:09 PM, Markus Armbruster <address@hidden> wrote:
>>
>> * device_add, qmp_capabilities
>>
>> Not QAPIfied, need everything.
>
> Some related commits from https://github.com/elmarco/qemu/commits/qapi
>
>
> https://github.com/elmarco/qemu/commit/e6828a0a926e20d3ee91ea956152b610ca30d2b8
>
> https://github.com/elmarco/qemu/commit/ba871db1c8d0edd0cbe7be716952f72c9df519a2
>
>>
>> * netdev_add, query-qmp-schema
>>
>> Need .args_type because of 'gen': false.
>>
>> * client_migrate_info, dump-guest-memory, query-dump, getfd, closefd,
>> add-fd, remove-fd, query-fdsets, migrate-set-capabilities
>>
>> Define .params and/or .help. Does this make any sense?
>>
>> A comment explaining which members need to be set would be nice.
>>
>> Have you checked Marc-André's work for overlap? Cc'ing him.
>
> yeah, it's conflicting with my work. Unfortunately, since I have been
> asked to wait since a long time, I am no longer on top of things, nor
> what I need to wait for. I have the feeling we really want
> qmp_dispatch() in monitor.c:
> https://github.com/elmarco/qemu/commit/af4158993088ee2bbf9087c440990880d7943eb1.
>
> Eric, I have been waiting for your series to settle for getting back
> to qapi, but it keeps growing ;) I hope you are familiar with the work
> I did in the branch so we don't duplicate efforts.
I'd very much prefer to give precedence to Marc-André's solution.
I think this patch is in this series just because the previous patch
notes a redundancy, and promises its cleanup. What about this:
* We shelve this patch for now, and s/a later patch/a future patch/ in
the previous patch's commit message.
* We continue to flush Eric's QAPI queue. If we come to a point where
we really want this patch, we insert it, and apologize to Marc-André.
But hopefully we come to a point where Marc-André's work fits first!
We'll refer to this patch when reviewing his solution, to make sure
we're not losing anything.
Okay?
- Re: [Qemu-devel] [PATCH v15 02/23] qapi: Guarantee NULL obj on input visitor callback error, (continued)
[Qemu-devel] [PATCH v15 01/23] qapi-visit: Add visitor.type classification, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 10/23] qmp-input: Require struct push to visit members of top dict, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 15/23] qmp: Support explicit null during visits, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 12/23] qapi: Document visitor interfaces, add assertions, Eric Blake, 2016/04/27