[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 10/11] qemu-iotests: test overlapping block-s
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v9 10/11] qemu-iotests: test overlapping block-stream operations |
Date: |
Wed, 27 Apr 2016 15:48:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
On 04.04.2016 15:44, Alberto Garcia wrote:
> This test case checks that it's not possible to perform two
> block-stream operations if there are nodes involved in both.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> tests/qemu-iotests/030 | 60
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/030.out | 4 ++--
> 2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
> index 1c53f80..6348872 100755
> --- a/tests/qemu-iotests/030
> +++ b/tests/qemu-iotests/030
> @@ -145,6 +145,66 @@ class TestSingleDrive(iotests.QMPTestCase):
> self.assert_qmp(result, 'error/class', 'GenericError')
>
>
> +class TestMultipleOps(iotests.QMPTestCase):
> + num_imgs = 9 # It must be > 5 or some tests will break
> + image_len = num_imgs * 1024 * 1024
> + imgs = []
> +
> + def setUp(self):
> + opts = []
> + self.imgs = []
> +
> + # Initialize file names and command-line options
> + for i in range(self.num_imgs):
> + img_depth = self.num_imgs - i - 1
> + opts.append("backing." * img_depth + "node-name=node%d" % i)
> + self.imgs.append(os.path.join(iotests.test_dir, 'img-%d.img' %
> i))
> +
> + # Create all images
> + iotests.create_image(self.imgs[0], self.image_len)
> + for i in range(1, self.num_imgs):
> + qemu_img('create', '-f', iotests.imgfmt,
> + '-o', 'backing_file=%s' % self.imgs[i-1], self.imgs[i])
> +
> + # Put data into some images so there's something to copy
> + for i in range(1, self.num_imgs, 2):
> + qemu_io('-f', iotests.imgfmt,
> + '-c', 'write -P %d %d %d' % (i, i*1024*1024, 1024*1024),
> + self.imgs[i])
> +
> + # Attach the drive to the VM
> + self.vm = iotests.VM()
> + self.vm.add_drive("blkdebug::" + self.imgs[-1], ','.join(opts))
Any special reason for blkdebug? For me it works just fine without.
With or without:
Reviewed-by: Max Reitz <address@hidden>
> + self.vm.launch()
> +
> + def tearDown(self):
> + self.vm.shutdown()
> + for img in self.imgs:
> + os.remove(img)
> +
> + # Test that it's not possible to perform two block-stream
> + # operations if there are nodes involved in both.
> + def test_overlapping(self):
> + self.assert_no_active_block_jobs()
> +
> + # Set a speed limit to make sure that this job blocks the rest
> + result = self.vm.qmp('block-stream', device='node4',
> base=self.imgs[0], speed=32768)
> + self.assert_qmp(result, 'return', {})
> +
> + result = self.vm.qmp('block-stream', device='node5',
> base=self.imgs[1])
> + self.assert_qmp(result, 'error/class', 'GenericError')
> +
> + result = self.vm.qmp('block-stream', device='node3',
> base=self.imgs[2])
> + self.assert_qmp(result, 'error/class', 'GenericError')
> +
> + result = self.vm.qmp('block-stream', device='node4')
> + self.assert_qmp(result, 'error/class', 'GenericError')
> +
> + self.wait_until_completed(drive='node4')
> + self.assert_no_active_block_jobs()
> +
> + self.vm.shutdown()
> +
> class TestSmallerBackingFile(iotests.QMPTestCase):
> backing_len = 1 * 1024 * 1024 # MB
> image_len = 2 * backing_len
> diff --git a/tests/qemu-iotests/030.out b/tests/qemu-iotests/030.out
> index 96961ed..b6f2576 100644
> --- a/tests/qemu-iotests/030.out
> +++ b/tests/qemu-iotests/030.out
> @@ -1,5 +1,5 @@
> -...............
> +................
> ----------------------------------------------------------------------
> -Ran 15 tests
> +Ran 16 tests
>
> OK
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.7 v9 00/11] Support streaming to an intermediate layer, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 06/11] block: Support streaming to an intermediate layer, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 01/11] block: keep a list of block jobs, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 10/11] qemu-iotests: test overlapping block-stream operations, Alberto Garcia, 2016/04/04
- Re: [Qemu-devel] [PATCH v9 10/11] qemu-iotests: test overlapping block-stream operations,
Max Reitz <=
- [Qemu-devel] [PATCH v9 08/11] docs: Document how to stream to an intermediate layer, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 04/11] block: use the block job list in bdrv_close(), Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 05/11] block: allow block jobs in any arbitrary node, Alberto Garcia, 2016/04/04