[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/2] vvfat: Fix volume name assertion

From: Kevin Wolf
Subject: [Qemu-devel] [PATCH 1/2] vvfat: Fix volume name assertion
Date: Wed, 27 Apr 2016 14:24:42 +0200

Commit d5941dd made the volume name configurable, but it didn't consider
that the rw code compares the volume name string to assert that the
first directory entry is the volume name. This made vvfat crash in rw

This fixes the assertion to compare with the configured volume name
instead of a literal string.

Cc: address@hidden
Signed-off-by: Kevin Wolf <address@hidden>
 block/vvfat.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index 6b85314..f9d4e82 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2288,7 +2288,11 @@ DLOG(fprintf(stderr, "commit_direntries for %s, 
parent_mapping_index %d\n", mapp
        if (ret)
            return ret;
-       assert(!strncmp(s->directory.pointer, "QEMU", 4));
+        /* The first directory entry on the filesystem is the volume name */
+        direntry_t *first_direntry = s->directory.pointer;
+        assert(!memcmp(first_direntry->name, s->volume_label, 11));
        current_dir_index += factor;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]