Re: [Qemu-devel] [V9 0/4] AMD IOMMU

[Marcel Apfelbaum]

On 04/25/2016 01:12 AM, David Kiarie wrote:
> Hi all,
>
> The current AMD IOMMU patches that fixes Igor's comments. I got rid of structs 
> and instead
> added individual integer fields into the table data directly, as suggested.
>
> I have also got rid of some un-used macros and fixed a few other miscellaneous 
> things.

My comments for V8 still stand. I don't see them addressed in this version.
Thanks,
Marcel

> David Kiarie (4):
>    hw/i386: Introduce AMD IOMMU
>    hw/i386: ACPI table for AMD IOMMU
>    hw/core: Add AMD IOMMU to machine properties
>    hw/pci-host: Emulate AMD IOMMU
>
>   hw/acpi/aml-build.c           |    2 +-
>   hw/acpi/core.c                |   13 -
>   hw/core/machine.c             |   32 +-
>   hw/i386/Makefile.objs         |    1 +
>   hw/i386/acpi-build.c          |  101 ++-
>   hw/i386/amd_iommu.c           | 1426 +++++++++++++++++++++++++++++++++++++++++
>   hw/i386/amd_iommu.h           |  398 ++++++++++++
>   hw/pci-host/q35.c             |   21 +-
>   include/hw/acpi/acpi-defs.h   |   14 +
>   include/hw/acpi/acpi.h        |   16 +
>   include/hw/acpi/aml-build.h   |    1 +
>   include/hw/boards.h           |    1 +
>   include/hw/i386/intel_iommu.h |    1 +
>   include/hw/pci/pci.h          |    2 +
>   qemu-options.hx               |    7 +-
>   util/qemu-config.c            |    8 +-
>   16 files changed, 2010 insertions(+), 34 deletions(-)
>   create mode 100644 hw/i386/amd_iommu.c
>   create mode 100644 hw/i386/amd_iommu.h