[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit |
Date: |
Fri, 22 Apr 2016 15:58:30 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.04.2016 um 15:49 hat Michael S. Tsirkin geschrieben:
> On Fri, Apr 22, 2016 at 06:55:59PM +0800, Fam Zheng wrote:
> > v2: Go along the is_external appraoch. [Kevin]
> >
> > I tested this series survives the "snapshot + commit" loop reproducer with
> > both
> > bonnie++ and RHEL installation in the guest.
> >
> > This supersedes the "virtio: Register host notifier handler as external"
> > patch
> > from yesterday.
> >
> > The bug was initially reported by Matthew Schumacher as LaunchPad Bug
> > 1570134,
> > and nicely bisected by Max Reitz. See patch 2 for the analysis.
>
> I reviewed patches 1-3 now.
> I could merge them but I'd rather not merge patches 4-5 myself though.
> Is there a reason why patches 4-5 are in the same series?
The fix doesn't work without them because the is_external handling in
the main loop is incomplete (i.e. even after aio_disable_external() it
would still process the AioHandlers sometimes)
> If not, pls submit them separately so block maintainers can merge them.
> Alternative have one of the block maintainers merge 1-3,
> I sent reviewed-by tags in that case.
I think it makes more sense to merge them in a single batch. I can
either take v3 through my tree as soon as Fam posts it or Peter can
apply the series directly.
Kevin
- [Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter, (continued)
- [Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion, Fam Zheng, 2016/04/22
- Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit, Michael S. Tsirkin, 2016/04/22