[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts |
Date: |
Fri, 22 Apr 2016 13:50:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben:
>> The iSCSI block driver has ability to lookup various options, in
>> particular authentication info, specified by the separate -iscsi
>> argument. It currently uses the iSCSI IQN as the ID value for this
>> lookup, however, this does not work for common iSCSI IQNs as they
>> contain characters such as ':' which are invalid for use as IDs.
>>
>> This adds an optional 'iscsi-id' parameter to the iSCSI block
>> driver to allow an explicit ID string to be used to reference
>> the -iscsi arg. For example
>>
>> $QEMU \
>> -iscsi id=my_initiator,user=fred,password-secret=sec0 \
>> -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>
This patch is cleaner and safer than "block: convert iscsi target to a
valid ID for -iscsi arg lookup".
> I would consider this a new feature rather than a fix appropriate for
> -rc4.
I'd be willing to spin this as a fix for a design bug, but I agree with
Kevin, it missed the boat. I might have supported it up until rc1 or
so.
- [Qemu-devel] [PATCH for-2.6] Fix association of -drive & -iscsi args, Daniel P. Berrange, 2016/04/22
- [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Daniel P. Berrange, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Kevin Wolf, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Peter Lieven, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Daniel P. Berrange, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Kevin Wolf, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Daniel P. Berrange, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Peter Maydell, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts, Daniel P. Berrange, 2016/04/22
- Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts,
Markus Armbruster <=