[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when queryi
From: |
Sylvain Garrigues |
Subject: |
Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer |
Date: |
Fri, 22 Apr 2016 13:26:55 +0200 |
Le 22 avr. 2016 à 13:22, Andrew Baumann <address@hidden> a écrit :
>> + stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres *
>> + (tmp_bpp >> 3));
>
> Personal style nit: I prefer * 8 rather than >> 3, because it's more
> immediately obvious what you're computing, a trivial optimisation for the
> compiler, and in this specific example wouldn't need the brackets to ensure
> the correct operator precedence.
>
> But in any case,
> Reviewed-by: Andrew Baumann <address@hidden>
Thanks! It is actually / 8, but I used >> 3 to remain consistent with what I
read in hw/display/bcm2835_fb.c. Feel free to adapt.
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, (continued)
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Peter Maydell, 2016/04/21
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Sylvain Garrigues, 2016/04/21
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Peter Maydell, 2016/04/21
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Sylvain Garrigues, 2016/04/21
- Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer, Stephen Warren, 2016/04/21
- Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer, Peter Crosthwaite, 2016/04/22
- Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer, Gerd Hoffmann, 2016/04/22
- Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer, Andrew Baumann, 2016/04/22
- Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer, Andrew Baumann, 2016/04/22
Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Andrew Baumann, 2016/04/22
- Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer,
Sylvain Garrigues <=
[Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer, Sylvain Garrigues, 2016/04/22