Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

[Sylvain Garrigues]

It does prevent FreeBSD to boot correctly.

With that patch and 
#define KERNEL_LOAD_ADDR 0x00200000
in arm/boot/boot.c, official FreeBSD RPI2 images boot like a charm :-)

BTW, would be great to be able to set the load addr on the command line, 
wouldn’t it?


> Le 21 avr. 2016 à 14:45, Peter Maydell <address@hidden> a écrit :
> 
> On 21 April 2016 at 11:41, Sylvain Garrigues
> <address@hidden> wrote:
>> As the framebuffer settings are copied into the result message before
>> it is reconfigured, inconsistent behavior can happen when, for instance,
>> you set with a sinle message the width, height, and depth, and ask at
>> the same time to allocate the buffer and get the pitch and the size.
>> 
>> In this case, the reported pitch and size would be incorrect as they
>> were computed with the initial values of width, height and depth, not
>> the ones the client requested.
> 
> Thanks for this patch. I think at this point in the 2.6 release cycle
> we should leave this for the 2.7 release, given that it doesn't affect
> the booting of the older Linux and Windows versions that work on the raspi2
> board.
> 
> I'll let Andrew review the patch...
> 
> -- PMM