[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags
Date: Wed, 20 Apr 2016 07:52:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 04/19/2016 04:21 PM, Emilio G. Cota wrote:
On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote:
We are inconsistent with the type of tb->flags: usage varies loosely
between int and uint64_t. Settle to uint32_t everywhere, which is
superior to both: at least one target (aarch64) uses the most significant
bit in the u32, and uint64_t is wasteful.

Compile-tested for all targets.

Suggested-by: Laurent Desnogues <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>

Has this patch been queued by anyone? If not, should I resend after
2.6 is released?

Sorry for the delay.  Queued for 2.7.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]