[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] pc: acpi: tpm: add missing MMIO resource to PCI0
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 3/6] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS |
Date: |
Thu, 14 Apr 2016 16:48:06 +0300 |
From: Igor Mammedov <address@hidden>
Windows will fail initialize TMP driver with the reason:
'device cannot find enough free resources'
That happens because parent BUS doesn't describe
MMIO resources used by TPM child device.
Fix it by describing it in top-most parent bus scope PCI0.
It was 'regressed' by commit
5cb18b3d TPM2 ACPI table support
with following fixup
9e472263 acpi: add missing ssdt
which did the right thing by moving TPM to BUS
it belongs to but lacked a proper resource declaration.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/i386/acpi-build.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 35180ef..784870e 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2167,6 +2167,11 @@ build_dsdt(GArray *table_data, GArray *linker,
0, pci->w64.begin, pci->w64.end - 1, 0,
pci->w64.end - pci->w64.begin));
}
+
+ if (misc->tpm_version != TPM_VERSION_UNSPEC) {
+ aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
+ TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
+ }
aml_append(scope, aml_name_decl("_CRS", crs));
/* reserve GPE0 block resources */
--
MST
- [Qemu-devel] [PULL 0/6] tpm, vhost, virtio: fixes for 2.6, Michael S. Tsirkin, 2016/04/14
- [Qemu-devel] [PULL 1/6] specs/vhost-user: improve VHOST_SET_VRING_NUM documentation, Michael S. Tsirkin, 2016/04/14
- [Qemu-devel] [PULL 2/6] specs/vhost-user: spelling fix, Michael S. Tsirkin, 2016/04/14
- [Qemu-devel] [PULL 4/6] tpm: acpi: remove IRQ from TPM's CRS to make Windows not see conflict, Michael S. Tsirkin, 2016/04/14
- [Qemu-devel] [PULL 3/6] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 5/6] tpm: Fix write to file descriptor function, Michael S. Tsirkin, 2016/04/14
- [Qemu-devel] [PULL 6/6] hw/virtio/balloon: Replace TARGET_PAGE_SIZE with BALLOON_PAGE_SIZE, Michael S. Tsirkin, 2016/04/14
- Re: [Qemu-devel] [PULL 0/6] tpm, vhost, virtio: fixes for 2.6, Peter Maydell, 2016/04/14