Re: [Qemu-devel] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D>

[Leon Alrae]

On 12/04/16 13:58, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
> 
> Updated handling of instuctions <ABS|NEG>.<S|D>. Note that legacy
> (pre-abs2008) ABS and NEG instructions are arithmetic (any NaN operand
> signals invalid operation), while abs2008 ones are non-arithmetic, always
> changing the sign bit, even for NaN-like operands. Details on these
> instructions are documented in [1] p. 35 and 359.
> 
> [1] "MIPS® Architecture For Programmers Volume II-A:
>     The MIPS64® Instruction Set Reference Manual",
>     Imagination Technologies LTD, Revision 6.04, November 13, 2015
> 
> Signed-off-by: Thomas Schwinge <address@hidden>
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  target-mips/translate.c |   27 +++++++++++++++++++++++----
>  1 file changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index de0b224..1d376fc 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -1434,6 +1434,8 @@ typedef struct DisasContext {
>      bool vp;
>      bool cmgcr;
>      bool mrp;
> +    bool abs2008;
> +

Blank line. Otherwise:

Reviewed-by: Leon Alrae <address@hidden>

Regards,
Leon