Re: [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes.

[Peter Maydell]

On 11 April 2016 at 11:29, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
> Here comes a virtio-input update, with a bugfix collection from Ladi
> Prosek and live migration support.
>
> please pull,
>   Gerd
>
> The following changes since commit 9628af036fade986dcc94f4484bc75c6b1a06d84:
>
>   Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160408' into 
> staging (2016-04-08 13:45:52 +0100)
>
> are available in the git repository at:
>
>
>   git://git.kraxel.org/qemu tags/pull-input-20160411-1
>
> for you to fetch changes up to e2392a72e88104272f3986f0846e4f2f45453b26:
>
>   virtio-input: fix emulated tablet axis ranges (2016-04-11 11:45:11 +0200)
>
> ----------------------------------------------------------------
> virtio-input; live migration support, various bugfixes.

Hi. I'm afraid this doesn't compile on ppc64be:

/home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest
parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
         .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
         ^
/home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest
parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
         .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
         ^

It looks like the const_le32() and const_le16() macros in
include/hw/virtio/virtio-input.h are missing brackets around the macro
argument -- can you send a patch which adds the missing brackets, please?

(Side question, why is an apparently generic endianness support
macro implemented in virtio-input.h ?)

thanks
-- PMM