[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdr
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close() |
|
Date: |
Thu, 7 Apr 2016 14:40:11 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.04.2016 um 19:57 hat Max Reitz geschrieben:
> The only caller of bdrv_close() left is bdrv_delete(). We may as well
> assert that, in a way (there are some things in bdrv_close() that make
> more sense under that assumption, such as the call to
> bdrv_release_all_dirty_bitmaps() which in turn assumes that no frozen
> bitmaps are attached to the BDS).
>
> In addition, being called only in bdrv_delete() means that we can drop
> bdrv_close()'s forward declaration at the top of block.c.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, (continued)
- [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call, Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot, Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c, Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs(), Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close(), Max Reitz, 2016/04/06
- Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close(),
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root(), Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS, Max Reitz, 2016/04/06
- [Qemu-devel] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close(), Max Reitz, 2016/04/06