Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

[Laurent Desnogues]

On Tue, Apr 5, 2016 at 7:19 PM, Richard Henderson <address@hidden> wrote:
> On 04/05/2016 09:33 AM, Laurent Desnogues wrote:
>> The 'flags' field is 64-bit.  You're thinking of cflags, I guess.
>
> Well that's silly.  Since it's filled in via
>
> static inline void cpu_get_tb_cpu_state(CPUMIPSState *env, target_ulong *pc,
>                                         target_ulong *cs_base, int *flags)
>
> and passed back in to generate code with
>
> TranslationBlock *tb_gen_code(CPUState *cpu,
>                               target_ulong pc, target_ulong cs_base, int 
> flags,
>                               int cflags);
>
> So while TranslationBlock stores "uint64_t", the producer and consumer see 
> "int".

I agree.  I guess TranslationBlock should be fixed to use uint32_t
(note several functions have to be changed from using int to uint32_t
or aarch64-softmmu will fail).


Laurent