|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 08/10] qht: QEMU's fast, resizable and scalable Hash Table |
Date: | Tue, 5 Apr 2016 11:01:07 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 05/04/2016 07:30, Emilio G. Cota wrote: > +static void qht_bucket_reset(struct qht_bucket *b) > +{ > + qemu_spinlock_lock(&b->lock); > + seqlock_write_begin(&b->sequence); > + __qht_bucket_reset(b); No __ names, please use names like qht_bucket_reset_locked. "_locked" doesn't make much sense for seqlock read-side critical sections, I think qht_do_lookup is good enough for that case. Otherwise, this is great stuff. :) Paolo > + seqlock_write_end(&b->sequence); > + qemu_spinlock_unlock(&b->lock); > +}
[Prev in Thread] | Current Thread | [Next in Thread] |