[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks |
|
Date: |
Fri, 1 Apr 2016 16:30:44 +0200 |
On Fri, 1 Apr 2016 16:14:22 +0200
Christian Borntraeger <address@hidden> wrote:
> On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> > Reentrancy cannot happen while the BQL is being held.
> >
> > Reviewed-by: Cornelia Huck <address@hidden>
> > Signed-off-by: Paolo Bonzini <address@hidden>
>
> Reverting this patch makes the segfaults go away.
>
>
>
>
>
> > ---
> > hw/block/dataplane/virtio-blk.c | 12 ++----------
> > hw/scsi/virtio-scsi-dataplane.c | 9 +--------
> > include/hw/virtio/virtio-scsi.h | 2 --
> > 3 files changed, 3 insertions(+), 20 deletions(-)
:(
On the one hand, I'm wondering what we're missing here.
On the other hand, let's just skip the cleanup patches and get the bug
fixed?
- Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler, (continued)
[Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 2/9] virtio: make virtio_queue_notify_vq static, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 5/9] virtio: add aio handler, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 8/9] virtio: merge virtio_queue_aio_set_host_notifier_handler with virtio_queue_set_aio, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 7/9] virtio-scsi: use aio handler for data plane, Paolo Bonzini, 2016/04/01
[Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane, Paolo Bonzini, 2016/04/01
Re: [Qemu-devel] [PATCH v2 0/9] virtio: aio handler API, Christian Borntraeger, 2016/04/01