[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA
|
From: |
Alex Bligh |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA |
|
Date: |
Thu, 31 Mar 2016 20:25:52 +0100 |
On 31 Mar 2016, at 20:14, Eric Blake <address@hidden> wrote:
>>
>>
>> Should we produce a new name for it (and future command flags)
>> that aren't shifted left 16 places, and just maintain the
>> current value for compatibility?
>
> I don't see the point. Your fix looks correct.
OK. And the wrongness hasn't yet got into /usr/include/linux/nbd.h
or include/uapi/linux/nbd.h ; these have no reference to FUA at all,
even though it does have NBD_FLAG_SEND_FLUSH, which is odd as I added
both flags at the same time.
So I'm guessing it's safe.
--
Alex Bligh
signature.asc
Description: Message signed with OpenPGP using GPGMail