[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet compariso

From: Li Zhijian
Subject: Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread
Date: Thu, 31 Mar 2016 10:17:53 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote:

>@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const uint8_t 
*buf, int size)
>      if (ret == 1) {
>          if (packet_enqueue(s, PRIMARY_IN)) {
>              error_report("primary: unsupported packet in");
>-            compare_chr_send(s->chr_out, buf, size);
>+            compare_chr_send(s->chr_out, s->pri_rs.buf, s->pri_rs.packet_len);
Doesn't that change belong in an earlier patch?

>+        } else {
>+            qemu_event_set(&s->event);
Also these - why are these in this patch?
This event is to wakeup comparison thread to do compare.
Do you think we should put event related code to patch 2 ?


>          }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]