[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throt

From: Alberto Garcia
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end
Date: Wed, 30 Mar 2016 14:24:55 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Thu 24 Mar 2016 05:39:23 PM CET, Paolo Bonzini wrote:
> Extract the handling of throttling from bdrv_flush_io_queue.  These
> new functions will soon become BdrvChildRole callbacks, as they can
> be generalized to "beginning of drain" and "end of drain".
> Signed-off-by: Paolo Bonzini <address@hidden>

I like the idea, thanks for the patch!

Reviewed-by: Alberto Garcia <address@hidden>

> +void bdrv_no_throttling_end(BlockDriverState *bs)
> +{
> +    --bs->io_limits_disabled;
>  }

Not very important, but you could assert that this doesn't go below 0.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]