[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/4] qemu-img: Fix preallocation with -S 0 fo

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 0/4] qemu-img: Fix preallocation with -S 0 for convert
Date: Tue, 29 Mar 2016 18:16:34 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 24.03.2016 um 23:33 hat Max Reitz geschrieben:
> Using -S 0 is supposed to allocate everything in the output image; or at
> least it is supposed to always explicitly write zeros even if the area
> in question is known to only contain zeros. That doesn't always work
> right now, so this series fixes it (patch 1, to be specific).
> I only noticed after I had written the test added by patch 4 that we
> already had an -S 0 test case which is included in the iotest 122.
> However, the test added here works for all image formats and is maybe
> more of a direct test (instead of querying the format whether it thinks
> it allocated all of the data we directly ask du whether everything has
> been allocated) so maybe it reflects better what users expect -S 0 to
> do. Maybe.
> Patches 2 and 3 are required for the test. I could have written the test
> without doing a convert with null-co as the source, but that would have
> been boring, so I did not.
> If you want to argue that in light of the existence of test 122 the new
> test added here is unnecessary and we therefore do not need patches 2, 3
> and 4, please go ahead. I won't put up too much of a fight.

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]