[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: fix segv on qemu_ram_free(block=0x0)
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: fix segv on qemu_ram_free(block=0x0) |
|
Date: |
Tue, 29 Mar 2016 13:27:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 29/03/2016 13:20, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Since f1060c55bf1377b4, the pointer is directly passed to
> qemu_ram_free(). However, on initialization failure, it may be called
> with a NULL pointer. Return immediately in this case.
>
> This fixes a SEGV when memory initialization failed, for example
> permission denied on open backing store /dev/hugepages, with -object
> memory-backend-file,mem-path=/dev/hugepages.
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x00005555556e67e7 in qemu_ram_free (block=0x0) at
> /home/elmarco/src/qemu/exec.c:1775
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Looks good, thanks! I'll push it during hard freeze.
Paolo