[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fi

From: Sergey Fedorov
Subject: Re: [Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields
Date: Tue, 29 Mar 2016 11:31:45 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 29/03/16 01:12, Richard Henderson wrote:
> On 03/24/2016 08:11 AM, Paolo Bonzini wrote:
>> There is also a case where a TB jumps to itself; it then appears twice
>> in the list with different values in the low bits, such as this:
>>      tb->jmp_list_first = tb | 0;
>>       .--------------------'   |
>>       |                .-------'
>>      tb->jmp_list_next[0] = tb | 2;
> Of course, it begs the question of why TB would be in its own list,
> even if it does jump to itself.  We only need the points-to list in
> order to invalidate a TB and unlink it.  But if TB is being
> invalidated, we don't need to reset the jump within TB itself.

If we're going to move tb_phys_invalidate() outside of tb_lock, we
probably need to reset all jumps to the TB, even if it jumps to itself,
so that it eventually finish its execution.

Kind regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]