[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/3] NBD proto: forbid TRIM command without negotiat

From: Denis V. Lunev
Subject: [Qemu-devel] [PATCH 1/3] NBD proto: forbid TRIM command without negotiation
Date: Mon, 28 Mar 2016 13:43:16 +0300

From: Pavel Borzenkov <address@hidden>

There is a loophole in the protocol that allows a client to send TRIM
request even if support for it wasn't negotiated with the server. State
explicitly that the client MUST NOT send such command without prior
successful negotiation.

Signed-off-by: Pavel Borzenkov <address@hidden>
Reviewed-by: Roman Kagan <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Wouter Verhelst <address@hidden>
CC: Eric Blake <address@hidden>
CC: Alex Bligh <address@hidden>
 doc/proto.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/proto.md b/doc/proto.md
index 6d1cb34..d54ed19 100644
--- a/doc/proto.md
+++ b/doc/proto.md
@@ -471,6 +471,9 @@ The following request types exist:
     about the contents of the export affected by this command, until
     overwriting it again with `NBD_CMD_WRITE`.
+    A client MUST NOT send a trim request unless `NBD_FLAG_SEND_TRIM`
+    was set in the export flags field.
 * Other requests
     Some third-party implementations may require additional protocol

reply via email to

[Prev in Thread] Current Thread [Next in Thread]