[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon() |
Date: |
Thu, 24 Mar 2016 09:31:00 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 23.03.2016 um 21:11 hat Max Reitz geschrieben:
> On 18.03.2016 11:31, Kevin Wolf wrote:
> > The call in hmp_drive_del() is dead code because blk_remove_bs() is
> > called a few lines above.
>
> Ah, so that's why I didn't have it in v3. Thanks for solving that
> mystery for me. :-)
I could have mentioned it in the review, but I figured it was quicker to
just send a follow-up patch.
> > The only other remaining user is
> > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the
> > named nodes list. This path inlines the list entry removal into
> > bdrv_delete() and removes bdrv_make_anon().
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > block.c | 15 +++------------
> > blockdev.c | 3 ---
> > include/block/block.h | 1 -
> > 3 files changed, 3 insertions(+), 16 deletions(-)
>
> Reviewed-by: Max Reitz <address@hidden>
Thanks.
Kevin
pgpdW9FYMHAUt.pgp
Description: PGP signature