[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.
Date: Wed, 23 Mar 2016 14:48:13 +0000

On 19 March 2016 at 20:59, Jean-Christophe Dubois <address@hidden> wrote:
> The sabrelite supports one SPI FLASH memory on SPI1
> Signed-off-by: Jean-Christophe Dubois <address@hidden>
> +    {
> +        /* Add the sst25vf016b NOR FLASH memory to first SPI */
> +        Object *spi_dev;
> +
> +        spi_dev = object_resolve_path_component(OBJECT(&s->soc), "spi1");

Can you add a comment to remind us there's a todo here:
 /* Ideally we would expose the chip select and spi bus on the SoC
  * object using alias properties; then we would not need to directly
  * access the underlying spi device object.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]