[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities int
Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface
Wed, 23 Mar 2016 15:06:35 +0100
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Peter Xu <address@hidden> writes:
> On Wed, Mar 23, 2016 at 10:52:29AM +0100, Markus Armbruster wrote:
>> The rule against returning non-dictionaries exists to avoid interfaces
>> that cannot evolve. With a dictionary, you can evolve by adding
>> The rule does *not* forbid returning lists of dictionaries. When a
>> command fundamentally returns a list of things, being able to evolve the
>> things suffices.
>> query-gic-capabilities looks like it fundamentally returns a list of
>> capabilities. Returning ['GICCapability'] is just fine then.
> I have posted v6 just as Eric has suggested. At least one advantage
> is that it is easier to be extended (if needed) in the future, also
> to follow the more-generic format to use dicts rather than
> arrays. If you would not mind, I'll keep the dict interface there.
Returning such a list of a structured type is a well-established
convention by now --- qmp-introspect.c shows 28 commands doing it, most
of them named query-FOO. I'd rather not start a different convention
now, just because we got temporarily confused about our own rules. So,
unless there's something about query-gic-capabilities that makes it more
likely to need extension outside its list element type, let's stick to
returning the list.
>> In either case, drop the change to returns_whitelist.
> Yep. Dropped in v6.
> -- peterx
[Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface, Peter Xu, 2016/03/17
Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface, Eric Blake, 2016/03/22
[Qemu-devel] [PATCH v5 3/5] arm: enhance kvm_arm_create_scratch_host_vcpu, Peter Xu, 2016/03/17
[Qemu-devel] [PATCH v5 4/5] kvm: add kvm_support_device() helper function, Peter Xu, 2016/03/17
[Qemu-devel] [PATCH v5 5/5] arm: implement query-gic-capabilities, Peter Xu, 2016/03/17
Re: [Qemu-devel] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command, Andrea Bolognani, 2016/03/21
- Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct, (continued)