Re: [Qemu-devel] [PATCH 10/22] qcow2-dirty-bitmap: add qcow2_bitmap_store()

[Vladimir Sementsov-Ogievskiy]

On 22.03.2016 21:49, Eric Blake wrote:
> On 03/15/2016 02:04 PM, Vladimir Sementsov-Ogievskiy wrote:
> > This function stores block dirty bitmap to qcow2. If the bitmap with
> > the same name, size and granularity already exists, it will be
> > rewritten, if the bitmap with the same name exists but granularity or
> > size does not match, an error will be genrated.
> s/genrated/generated/
>
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> > +
> > +/* if no id is provided, a new one is constructed */
> > +static int qcow2_bitmap_create(BlockDriverState *bs, const char *name,
> > +                               uint64_t size, int granularity)
> > +{
> > +    int ret;
> > +    BDRVQcow2State *s = bs->opaque;
> > +
> > +    if (s->nb_bitmaps >= QCOW_MAX_DIRTY_BITMAPS) {
> > +        return -EFBIG;
> > +    }
> > +
> > +    /* Check that the name is unique */
> > +    if (find_bitmap_by_name(bs, name) != NULL) {
> > +        return -EEXIST;
> > +    }
> > +
> Is the comment about constructing a name stale or misplaced?

It's a mistake, thanks. Don't remember, where I stole it)

--
Best regards,
Vladimir