qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] tcg: reorganize tb_find_physical loop


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/5] tcg: reorganize tb_find_physical loop
Date: Tue, 22 Mar 2016 16:00:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0


On 22/03/2016 15:59, Alex Bennée wrote:
>> > +    for (ptb1 = &tcg_ctx.tb_ctx.tb_phys_hash[h];
>> > +         (tb = *ptb1) != NULL;
>> > +         ptb1 = &tb->phys_hash_next) {
> I'm not sure I'm keen on the assignment in the for condition clause. I
> appreciate the cleansing of the if !tb return exit though. Could we be
> cleaner maybe? Here is my attempt:

Sure, that would be just fine.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]